feat(browser): set a default device size for the in-app preview by heyitsaadin · Pull Request #2966 · Acode-Foundation/Acode

heyitsaadin · 2026-10-10T23:14:55Z

What
The in-app preview browser always opens in the phone's native mobile view. This adds a way to choose a default preview size.

How it works

Turn on Devices, then pick a preset or set a custom Width/Height/Scale.
New menu item Set as Default saves the current size. Clear Default removes it.
When a default is set, the preview opens in Devices mode with that size.
Without a saved default, behavior is unchanged.

Implementation
Values are stored in SharedPreferences (acode_browser). Changes are limited to Browser.java and Emulator.java.

Notes

Saved values are screen pixels (clamped on restore), so custom sizes are device-specific.
Happy to move this into the Settings page instead if you'd prefer.

Related: "Html Rendering options" feature request on Discord.

heyitsaadin · 2026-10-11T04:10:12Z

greptile-apps · 2026-10-11T04:13:56Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; the startup reload is fixed and no new blocking issue was found.

Summary

The PR saves a default preview size and restores it when the browser opens.

The in-app preview opens with your saved device size.

The previous startup-reload finding is fixed. No new actionable issues were found.

_{Reviews (2) · Last reviewed commit: "fix(browser): only apply dimensions afte..." · Reviewed by Greptile}

… a reload

bajrangCoder · 2026-10-11T11:23:21Z

+    int width = Math.min(
+      prefs.getInt("default_width", widthSeekBar.getMax()),
+      widthSeekBar.getMax()
+    );
+    int height = Math.min(
+      prefs.getInt("default_height", heightSeekBar.getMax()),
+      heightSeekBar.getMax()
+    );
+
+    widthSeekBar.setProgress(width);
+    heightSeekBar.setProgress(height);
+    setMaxScale(width, height);
+    int scale = Math.min(
+      prefs.getInt("default_scale", 100),
+      scaleSeekBar.getMax()
+    );
+    scaleSeekBar.setProgress(scale);
+
+    String name = prefs.getString("default_device", "Custom");
+    for (Device device : deviceListView.devices) {
+      if (device.name.equals(name)) {
+        if (deviceListView.selectedDeviceView != null) {
+          deviceListView.selectedDeviceView.deselect();
+        }
+        deviceListView.select(device);
+        selectedDevice = device;
+        break;
+      }
+    }


When the screen size changes, a saved preset comes back with the wrong shape.

The saved width/height are screen pixels taken after selectDevice fitted the preset to the screen at save time. Here they're clamped separately with Math.min, and then the preset is highlighted by name. selectDevice instead shrinks both sides by the same ratio.

Example: save "iPad" in portrait, then open the preview in landscape, split-screen, or on the other screen of a foldable. The width stays the same and only the height gets cut, but the list still shows "iPad". (BrowserActivity handles orientation|screenSize itself, so the screen size really does vary between opens.)

Suggestion: if the saved name is a preset, call selectDevice(device) so it refits to the current screen, then apply the saved scale. Keep the raw width/height restore only for "Custom".

Good catch. A saved preset is now re-fitted with selectDevice() to the current screen, then the saved scale is applied. Raw width/height is only used for Custom. Tested by saving Laptop in portrait and reopening in landscape

bajrangCoder · 2026-10-11T11:23:21Z

+
+    // Apply the saved mode before the first navigation so the page is not
+    // loaded with the wrong user agent and then reloaded.
+    setDesktopMode(true, false);


The desktop user agent is set before the first load (good), but the first page load still happens at full size, not at the saved size.

BrowserActivity.onCreate calls browser.setUrl(url) right after the constructor, before any layout happens. The saved size only arrives two layout passes later: first the webview's layout listener below, then the emulator's own listener in setReference, which calls restoreDefaultDevice. So the page starts loading at the full webview width and is resized partway through.

CSS media queries will adjust after the resize, but scripts that read innerWidth or measure the layout once on load will keep the full-size values. A fast localhost server may even finish the page before the resize. Switching Devices on by hand doesn't have this problem, because it reloads after the size is applied.

This depends on timing, so could you check it on a device with a page that logs innerWidth on load? If it reproduces, reload once after the saved size is applied, but only if the page has already started loading.

The page now reloads once after the saved size is applied, and only if a page was already requested.

bajrangCoder · 2026-10-11T11:23:21Z

+            menu.setChecked("Console", false);
+            menu.setVisible("Console", false);
+            addView(deviceEmulator);
+            fitWebViewTo(


Minor: at this point the emulator hasn't set up its sliders yet (setReference does that in a later layout pass). So this call shrinks the webview to a placeholder size and pushes that size into the page's viewport before the real size is applied. Switching Devices on by hand has the same flicker, but now it happens during the first page load. Could this call be skipped here and the size left to restoreDefaultDevice?

restoreDefaultDevice handles sizing now

bajrangCoder · 2026-10-11T11:23:21Z


+  private void updateDefaultItems(boolean emulatorOn) {
+    menu.setVisible("Set as Default", emulatorOn);
+    menu.setVisible("Clear Default", emulatorOn);


Nit: "Clear Default" shows up in Devices mode even when nothing is saved, and the toast still says "Default cleared". Show it only when Emulator.hasDefault(context) is true, and update its visibility after Set/Clear.

Now shown only when hasDefault() is true, and refreshed after Set/Clear.

…ested

…e-Foundation#2966) * refactor(browser): keep a list of devices in the emulator device list * refactor(browser): register each device when added to the list * feat(browser): apply the saved default preview size once layout is ready * feat(browser): save and restore a default device preview size * feat(browser): add "Set as Default" and "Clear Default" menu items * feat(browser): handle "Set as Default" and "Clear Default" actions * feat(browser): show default menu items only while Devices mode is on * feat(browser): open the preview in Devices mode when a default is set * feat(browser): restore the default preview mode on startup * refactor(browser): allow applying desktop mode without reloading * refactor(browser): make the reload in setDesktopMode optional * fix(browser): apply saved desktop mode before the first load to avoid a reload * fix(browser): only apply dimensions after layout, not desktop mode * fix(browser): re-fit saved presets to the current screen on restore * fix(browser): reload once after the saved size is applied * fix(browser): don't resize the webview before the emulator is set up * fix(browser): add reloadAfterLayout helper, only when a page was requested * fix(browser): show "Clear Default" only when a default is saved * fix(browser): refresh default menu items after Set as Default * fix(browser): refresh default menu items after Clear Default

heyitsaadin added 9 commits October 11, 2026 04:38

refactor(browser): keep a list of devices in the emulator device list

45289ab

refactor(browser): register each device when added to the list

64b915d

feat(browser): apply the saved default preview size once layout is ready

fc7e8d9

feat(browser): save and restore a default device preview size

fced123

feat(browser): add "Set as Default" and "Clear Default" menu items

91f3ca2

feat(browser): handle "Set as Default" and "Clear Default" actions

615296b

feat(browser): show default menu items only while Devices mode is on

8fd2c31

feat(browser): open the preview in Devices mode when a default is set

4791cba

feat(browser): restore the default preview mode on startup

bbf48d8

github-project-automation Bot added this to The Code Board - Acode Oct 10, 2026

github-actions Bot added the enhancement New feature or request label Oct 10, 2026

heyitsaadin marked this pull request as ready for review October 11, 2026 04:10

greptile-apps Bot reviewed Oct 11, 2026

View reviewed changes

Comment thread src/plugins/browser/android/com/foxdebug/browser/Browser.java Outdated

heyitsaadin added 4 commits October 11, 2026 09:46

refactor(browser): allow applying desktop mode without reloading

28d28bc

refactor(browser): make the reload in setDesktopMode optional

752a64c

fix(browser): apply saved desktop mode before the first load to avoid…

477aedc

… a reload

fix(browser): only apply dimensions after layout, not desktop mode

e0a18db

This comment was marked as outdated.

Sign in to view

bajrangCoder reviewed Oct 11, 2026

View reviewed changes

heyitsaadin added 7 commits October 11, 2026 18:53

fix(browser): re-fit saved presets to the current screen on restore

5a53452

fix(browser): reload once after the saved size is applied

b43da8f

fix(browser): don't resize the webview before the emulator is set up

c7fcd73

fix(browser): add reloadAfterLayout helper, only when a page was requ…

4c629f7

…ested

fix(browser): show "Clear Default" only when a default is saved

1d23d80

fix(browser): refresh default menu items after Set as Default

bf0ec37

fix(browser): refresh default menu items after Clear Default

7f4afd8

heyitsaadin mentioned this pull request Oct 11, 2026

Sync review fixes for default preview device into fork main heyitsaadin/Acode#2

Merged

bajrangCoder approved these changes Oct 13, 2026

View reviewed changes

bajrangCoder added this pull request to the merge queue Oct 13, 2026

Merged via the queue into Acode-Foundation:main with commit f432f33 Oct 13, 2026
7 checks passed

github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Oct 13, 2026

Navigation Menu

Repository navigation

feat(browser): set a default device size for the in-app preview - #2966

feat(browser): set a default device size for the in-app preview#2966
bajrangCoder merged 20 commits into
Acode-Foundation:mainfrom
heyitsaadin:feat/preview-default-device

heyitsaadin commented Oct 10, 2026

Uh oh!

heyitsaadin commented Oct 11, 2026

Uh oh!

greptile-apps Bot commented Oct 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

This comment was marked as outdated.

bajrangCoder Oct 11, 2026

Uh oh!

heyitsaadin Oct 11, 2026

Uh oh!

bajrangCoder Oct 11, 2026

Uh oh!

heyitsaadin Oct 11, 2026

Uh oh!

bajrangCoder Oct 11, 2026

Uh oh!

heyitsaadin Oct 11, 2026

Uh oh!

bajrangCoder Oct 11, 2026

Uh oh!

heyitsaadin Oct 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

heyitsaadin commented Oct 10, 2026

Uh oh!

heyitsaadin commented Oct 11, 2026

Uh oh!

greptile-apps Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

This comment was marked as outdated.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Oct 11, 2026 •

edited

Loading