Repository navigation
Commit a6c7dba
test(submodule): close retained parent before checkout removal
The Windows Python 3.14 job for PR #2274 failed in
`TestSubmodule.test_base_rw` when forced module-only removal called
`rmtree`: Windows reported `WinError 32` for `git/ext/gitdb`.
The legacy test retains that checkout's `Repo` through `csm.repo` and
starts its persistent `cat-file` process while reading parent commits.
Closing only the fresh handle created by `Submodule.remove()` cannot
release this caller-owned process.
Close the retained test-owned parent before deleting its checkout. Keep
strict removal and all existing happy-path assertions, and remove the
obsolete commented-out skip that claimed removal ignored this error.
The original test predates the PR's base, so record this as a follow-up
rather than rewriting shared history.
The focused `test_base_rw` passed locally with both CLI and Gix.
Relevant pre-commit hooks passed. Hosted Windows validation remains
part of the PR CI loop.1 parent 9ef9ca6 commit a6c7dba
1 file changed
Lines changed: 1 addition & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1308 | 1308 | | |
1309 | 1309 | | |
1310 | 1310 | | |
| 1311 | + | |
1311 | 1312 | | |
1312 | 1313 | | |
1313 | 1314 | | |
| |||
1410 | 1411 | | |
1411 | 1412 | | |
1412 | 1413 | | |
1413 | | - | |
1414 | | - | |
1415 | | - | |
1416 | | - | |
1417 | | - | |
1418 | | - | |
1419 | | - | |
1420 | 1414 | | |
1421 | 1415 | | |
1422 | 1416 | | |
| |||
0 commit comments